Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bundle size improvements #1983

Merged
merged 2 commits into from
Nov 10, 2018
Merged

feat: bundle size improvements #1983

merged 2 commits into from
Nov 10, 2018

Conversation

DavidRouyer
Copy link
Contributor

@DavidRouyer DavidRouyer commented Nov 10, 2018

Related issues

#1966, #1967

Short description and why it's useful

  • Replace he.js with https://github.com/adnaan1703/lean-he (tree shaked version to only use decode)
  • Replace object-hash with https://github.com/emn178/js-sha3 (smaller, plus MD5 and SHA1 algorithms are obsolete)
  • Move webpack-bundle-analyzer to webpack.client to avoid launching multiple version of the server
  • Refactor lodash imports to enable lodash-es tree shaking
  • Bump dependencies

Screenshots of visual changes before/after (if there are any)

before
after

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

(run yarn test:e2e and paste the results. If you are not using our standard backend setup or demo.vuestorefront.io you can ommit this step)

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks!

@pkarw pkarw merged commit a8b47de into vuestorefront:develop Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants