Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundlesize config #2003

Merged
merged 2 commits into from
Nov 18, 2018
Merged

Conversation

jahvi
Copy link
Contributor

@jahvi jahvi commented Nov 16, 2018

Related issues

#1293, #1294, #1966

Short description and why it's useful

There's been a few issues targeted at improving the bundle size, integrating bundlesize in the CI checks should help keep track of how the bundles are changing across commits and PRs so it's easier to see how big or small they get. You can check this dummy PR in my fork that adds an extra library that makes the bundle size bigger than the set maximum.

I'm just adding the app, vendor and manifest files to the check with some sensible maximum file sizes but this can be tweaked.

Screenshots of visual changes before/after (if there are any)

PR Screen
screen shot 2018-11-16 at 11 28 18 pm

Bundle Size Details
screen shot 2018-11-16 at 11 20 03 pm

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

TBA

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@filrak
Copy link
Collaborator

filrak commented Nov 18, 2018

Great addition, thank you! ;)

@filrak filrak merged commit 927fe07 into vuestorefront:develop Nov 18, 2018
@jahvi
Copy link
Contributor Author

jahvi commented Nov 18, 2018

Thanks! Keep in mind that to make the check show in PRs someone with admin rights needs to authorise bundlesize with travis as shown in their readme:
https://github.com/siddharthkp/bundlesize#2-build-status

@jahvi jahvi deleted the feat/add-bundlesize branch November 18, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants