1864 simply productbundleoptions #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Have You tested it with Bundle products on demo data set? |
|
@pkarw sure, test example can be Sprite Yoga Companion Kit ;) |
pkarw
reviewed
Nov 20, 2018
pkarw
reviewed
Nov 20, 2018
patzick
commented
Nov 20, 2018
pkarw
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#1864
Short description and why it's useful
I've separated ProductBundleOption from ProductBundleOptions. It has simplified structure a little bit.
Tried not to touch too much at once to avoid business logic errors.
There are no visual changes.