Always add magento2 api configuration #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
requested changes
Nov 28, 2018
| config.magento2.api.consumerSecret = this.answers.m2_api_consumer_secret | ||
| config.magento2.api.accessToken = this.answers.m2_api_access_token | ||
| config.magento2.api.accessTokenSecret = this.answers.m2_api_access_token_secret | ||
| config.magento2.imgUrl = urlParser(this.answers.images_endpoint).href |
There was a problem hiding this comment.
Shouldnt be default fallback applied here as well? @Cyclonecode
There was a problem hiding this comment.
@pkarw
Nope, not really since the this.answers.images_endpoint is always set in this stage.
If you are not using the default (https://demo.vuestorefront.io) as a backend you will be prompted to choose the images endpoint even if you later decide not to setup credentials or am I missing something:
Choose path for images endpoint (Use arrow keys)
❯ https://demo.vuestorefront.io/img/
http://localhost:8080/img/
Custom url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#1847
#1842
vuestorefront/mage2vuestorefront#29 (comment)
Short description and why it's useful
The magento2.imgUrl and also the magento2.api.* should always be stored in configuration.
If not the default backend (https://demo.vuestorefront.io) is used, then the user will be asked to supply the magento2 url and also choose to setup credentials and import data to elasticsearch. If the user does not choose to setup credentials, then the defaults from
vue-storefront/config/default.jsonfile will be used.Screenshots of visual changes before/after (if there are any)
(if you made any changes in the UI layer please provide before/after screenshots)
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
(run
yarn test:e2eand paste the results. If you are not using our standard backend setup or demo.vuestorefront.io you can ommit this step)Upgrade Notes and Changelog
Contribution and currently important rules acceptance