Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Old doc folder removed #2041

Merged
merged 13 commits into from
Dec 1, 2018
Merged

[Docs] Old doc folder removed #2041

merged 13 commits into from
Dec 1, 2018

Conversation

NataliaTepluhina
Copy link
Contributor

  1. Removed doc folder
  2. Changed README to have images/links/etc. from the new docs folder
  3. Added stylesheets doc.
  4. Removed sync state.

@filrak
Copy link
Collaborator

filrak commented Nov 30, 2018

Perfect ! Thanks Natalia!
Is it ready to merge in?

@pkarw
Copy link
Collaborator

pkarw commented Nov 30, 2018

I've checked the removed files and it seems that we're missing the following - still quite accurate docs:

  • doc/E2E tests.md
  • doc/Extending vue-storefront-api.md
  • doc/Extending Express.js server side routes.md
  • doc/Payment Gateway Integration.md
  • doc/Upgrade notes.md

@NataliaTepluhina I think these docs are pretty important, can You just move them to the new structure so we could remove /doc once and for all?

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to migrate some crucial docs - that are still accurate - to the new structure

@NataliaTepluhina
Copy link
Contributor Author

NataliaTepluhina commented Nov 30, 2018

@pkarw

  • doc/E2E tests.md
  • doc/Extending vue-storefront-api.md
  • doc/Extending Express.js server side routes.md
  • doc/Payment Gateway Integration.md
  • doc/Upgrade notes.md

@NataliaTepluhina
Copy link
Contributor Author

@pkarw Please review latest changes

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @NataliaTepluhiba we’re almost there! The only missing part is about the modules. We should have at least https://github.com/DivanteLtd/vue-storefront/blob/cf31a3fe314854e61f5e40ec5443236f3d90c611/doc/api-modules/about-modules.md moved to new docs before removing /doc folder. @filrak WDYT?

@pkarw
Copy link
Collaborator

pkarw commented Nov 30, 2018

After adding basic docs about modules we are ready to merge this in - I’ve checked the rest and seeems fine

@NataliaTepluhina
Copy link
Contributor Author

@pkarw done :)

@pkarw pkarw merged commit f1659ac into develop Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants