Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share webpack typescript config with docker container #2269

Merged

Conversation

lukeromanowicz
Copy link
Contributor

Short description and why it's useful

Current typescript config for webpack building is not shared with docker containers which causes being unable to build with webpack config written TS.

Screenshots of visual changes before/after (if there are any)

image

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@filrak filrak merged commit 3954716 into vuestorefront:develop Jan 21, 2019
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants