Feature/product gallery image blinking #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That’s fine but shouldn’t we have a placeholder while image is loading? |
pkarw
approved these changes
Feb 21, 2019
filrak
approved these changes
Feb 22, 2019
patzick
added
the
QA - Ready for tests
This was referenced Feb 22, 2019
|
Verified with #2482 |
ibugaj
added
QA approved on branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Short description and why it's useful
Corrects product gallery thumbnails, reduces first gallery slide when specific product color is chosen and turns off default lazy animation which causes blinking on gallery.
Screenshots of visual changes before/after (if there are any)
Gifs below are converted from mov files and for some reason are slowed down. Animations are faster, but generally shows the difference.
Before
After
Upgrade Notes and Changelog