Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove single image on product page, always show a gallery #2488

Merged
merged 4 commits into from
Feb 25, 2019

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Feb 22, 2019

Related issues

#2481

Short description and why it's useful

Always display a gallery, even if there is only one image.
There was no option to zoom single image, and loading caused a jump effect. Now gallery will be consistent.

Screenshots of visual changes before/after (if there are any)

Before

gal_before

After

gal_after

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

@patzick patzick requested review from pkarw and filrak February 22, 2019 22:45
@patzick patzick added this to the 1.9 milestone Feb 24, 2019
@filrak filrak merged commit 6862fa4 into vuestorefront:develop Feb 25, 2019
@patzick patzick modified the milestones: 1.9, 1.8.3 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants