set default storeId to 1 instead of 0 so default magento storeId is q… #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filrak
reviewed
Mar 17, 2019
| @@ -54,7 +54,7 @@ export default { | |||
| return currentStoreView() | |||
| }, | |||
| storeView () { | |||
| return (this.isMultistoreEnable && this.currentStore) ? this.currentStore.storeId : 0 | |||
| return (this.isMultistoreEnable && this.currentStore) ? this.currentStore.storeId : 1 | |||
There was a problem hiding this comment.
since storeID is set to '1' by default it can be false therefore the last check is redundant. Am I right?
There was a problem hiding this comment.
@filrak I don't think so.
what the above condition seems to do is:
- if you have multistore and the current store has been correctly set, use
this.currentStore.storeId(from multistore module) - else (multistore is disabled or this.currentStore is empty) use cms fallback (not taken from multistore fallback)
there might be some magic logic I cannot find but when we tried, both of those had to be set separately (depending on multistore setup we had). Based on that I think this still require to set BOTH fallbacks this way.
patzick
requested changes
Mar 24, 2019
added 2 commits
March 25, 2019 13:28
…ueried instead of 0 which never has chance of existence as primary key
|
@patzick rebased on master and added changelog |
patzick
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ueried instead of 0 which never has chance of existence as primary key
Related issues
none
Short description and why it's useful
cmsModule by default uses endpoint:
https://github.com/DivanteLtd/vue-storefront/blob/master/config/default.json#L405
but the storeId is set to
0. This PR is made for default magento storeId1to be queried instead of0.0 storeId doesn't exist in default magento instances (nor any instance which usually supports primary keys).
Screenshots of visual changes before/after (if there are any)
no changes
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
none, but storeId is nowhere compared to fallback value
0Upgrade Notes and Changelog
Contribution and currently important rules acceptance