config change - added api url #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patzick
approved these changes
Mar 21, 2019
filrak
previously requested changes
Mar 25, 2019
|
Please add it to the installer as well |
|
@BartoszLiburski can we add this change to installer and merge this one in? |
patzick
approved these changes
Apr 2, 2019
|
I added change to installer and updated changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we use vsf-api for every request, writing new module/action/etc with request to vsf-api we need to add new whole url to api side, like: http://localhost:8080/my-extension/foo
It looks bad and generates problems, if someone forget to update config on new module install.
I think it is better to use
config.api.urlin modules, than forcing user to create updates in config file.