Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event on BaseSelect input -> change #2683

Merged

Conversation

ResuBaka
Copy link
Collaborator

@ResuBaka ResuBaka commented Apr 5, 2019

Short description and why it's useful

Changed that den BaseSelect emits a change event and an input event. With this the component now throws the native events that an select element would throw.
For more information here.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

The change event has emitted a input event instead of a change event that the normal select element would throw.
An select element throws both an input and an change event. With this both event are now thrown by the baseSelect.
I got the info from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select#See_also (Events fired by <select>: change, input.).
@patzick patzick changed the base branch from develop to develop_merge April 9, 2019 12:31
@patzick patzick merged commit 93d5559 into vuestorefront:develop_merge Apr 9, 2019
@patzick
Copy link
Collaborator

patzick commented Apr 9, 2019

Thanks @ResuBaka !

@patzick patzick added this to the 1.10.0-rc.1 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants