Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/back to top: Integrated back to top functionality #2866

Merged
merged 9 commits into from May 14, 2019

Conversation

vishal-7037
Copy link
Contributor

Related issues

closes #2864

Short description and why it's useful

Integrated back to top functionality

Screenshots of visual changes before/after (if there are any)

2019_05_07_Back_to_top

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented May 7, 2019

Hi! Thanks, please just update the Changelog :)

@pkarw pkarw requested a review from patzick May 7, 2019 13:56
@pkarw pkarw added this to the 1.10.0-rc.1 milestone May 7, 2019
@vishal-7037
Copy link
Contributor Author

Hi @pkarw,

Change log added.

Thanks!

@pkarw pkarw mentioned this pull request May 10, 2019
5 tasks
Copy link
Collaborator

@filrak filrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the PR. I believe this could be just a simple component rather than module since there is no additional functionality there (liek vuex/router intercations etc).

@vishal-7037
Copy link
Contributor Author

Hi, @filrak,

So, it should be moved in the theme core component from the module?
Am I right?

@vishal-7037
Copy link
Contributor Author

Hi, @filrak,

I've moved it to the theme component directory and seems working fine.

Please review it and let me know.

Thanks!

@pkarw pkarw requested a review from filrak May 12, 2019 06:18
@filrak
Copy link
Collaborator

filrak commented May 14, 2019

Hey, thank you! ;) Now everything looks good ^^

@filrak filrak merged commit cc190c9 into vuestorefront:develop May 14, 2019
@alinadivante alinadivante added the QA approved after merge Testers will add this label after positive check on merged changes label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants