Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication fom Travis config #3035

Merged
merged 5 commits into from
Jun 10, 2019

Conversation

Tjitse-E
Copy link
Contributor

@Tjitse-E Tjitse-E commented Jun 9, 2019

Short description and why it's useful

I was looking at the current Travis config and I noticed that the build/test stage was there twice (one time fo each supported NodeJS version). Using the YAML anchor function we can remove that duplication. This will also lead to a smaller Travis config in the future, for example, if we want to support Node v12.

This change is also merged into the VS API, so it makes sense to also apply it here.

I've enabled the installer tests for NodeJS v10. I do not know why it was only tested for NodeJS v8 before.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw pkarw merged commit ff1151e into vuestorefront:develop Jun 10, 2019
@Tjitse-E Tjitse-E deleted the feature/refactor-travis branch June 10, 2019 07:59
@patzick patzick added this to the 1.10.0-rc.1 milestone Jun 10, 2019
@patzick patzick added the vs-hackathon Tasks for the Hackathon label Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants