Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dynamic urls name should only be prefixed when appendStoreCode is true #3685

Conversation

ResuBaka
Copy link
Collaborator

@ResuBaka ResuBaka commented Oct 4, 2019

Related issues

closes #

Short description and why it's useful

This is a fix for when you have the defaultStoreCode set to an storeView
for example de and have appendStoreCode false and url as /. Then it
currently does not work when multistore is active.

With this is does work as the base url is now the de store with no prefix
in the dynamic url name.

You can still switch to to it store and there all urls work.

Testet against the https://next.storefrontcloud.io api.

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

…s true

This is a fix for when you have the baseStore set to an storeView store
for example de and have appendStoreCode false and url as /. Then it
currently does not work when multistore is active.

With this is does work as the base url is now the de store with no prefix
in the dynamic url name.
@andrzejewsky andrzejewsky merged commit a81f99f into vuestorefront:release/v1.11 Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants