Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed possible memory leak in ssr #4247

Merged
merged 2 commits into from Apr 15, 2020

Conversation

ResuBaka
Copy link
Collaborator

Short Description and Why It's Useful

When current currentStoreView() is saved in an variable outside of the export it is not clean up automatically on the SSR side. To fix that I replaced all places that used the variable with the function call. Which fixes the problem.

The problem is currently not directly in the theme as in the default way the InstantCheckout.vue is not rendered on the SSR, but for every body that may change the theme and then renders the InstantCheckout.vue on SSR there it would lead to an memory leak so it should be fixed.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

When current currentStoreView() is saved in an variable outside of the export it is not clean up automatically
on the SSR side.
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pkarw pkarw requested a review from gibkigonzo April 14, 2020 17:29
@gibkigonzo gibkigonzo merged commit 22d9904 into vuestorefront:develop Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants