Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import vcard with VERSION:4.0 #202

Closed
Thalley opened this issue Apr 4, 2023 · 5 comments
Closed

Cannot import vcard with VERSION:4.0 #202

Thalley opened this issue Apr 4, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Thalley
Copy link

Thalley commented Apr 4, 2023

When attempting to import my contacts to my DivestOS (build 20.0) I was met with an error message that it could not import the .vcf (vCard) file.

I played around with the vCards in the file, and found that simply modifying the version from VERSION:4.0 to VERSION:3.0 made it work, so the (default) Contacts application may not (properly) support VERSION:4.0.

See the following examples:

This works

BEGIN:VCARD
VERSION:2.1
N:;Test Name;;;
FN:Test Name
END:VCARD

And this works

BEGIN:VCARD
VERSION:3.0
N:;Test Name;;;
FN:Test Name
END:VCARD

but this doesn't work

BEGIN:VCARD
VERSION:4.0
N:;Test Name;;;
FN:Test Name
END:VCARD
@SkewedZeppelin
Copy link
Member

The underlying AOSP Contacts app largely hasn't been updated since 2014 or so making issues like this expected.

@SkewedZeppelin SkewedZeppelin added the bug Something isn't working label Apr 4, 2023
@Thalley
Copy link
Author

Thalley commented Apr 4, 2023

The underlying AOSP Contacts app largely hasn't been updated since 2014 or so making issues like this expected.

That makes sense. Maybe it's worth raising an issue for the AOSP, instead of here then?

@SkewedZeppelin
Copy link
Member

SkewedZeppelin commented Apr 4, 2023

Nah, they're deprecated in favor of their proprietary replacements, eg: https://play.google.com/store/apps/details?id=com.google.android.contacts

and merely considered "reference implementations" these days.

@Thalley
Copy link
Author

Thalley commented Apr 4, 2023

Nah, they're deprecated in favor of their proprietary replacements, eg: https://play.google.com/store/apps/details?id=com.google.android.contacts

and merely considered "reference implementations" these days.

I see. Would the best option be to update it for DivestOS, or to update the implement in the AOSP?

On a related note, I don't know which labels exists for this repo, but I probably wouldn't call this a bug, but rather an enhancement (unless it is supposed to support version 4.0 already).

@SkewedZeppelin SkewedZeppelin added enhancement New feature or request and removed bug Something isn't working labels Apr 4, 2023
@SkewedZeppelin
Copy link
Member

I'll look to pulling this in next update: GrapheneOS/platform_packages_apps_Contacts@8fbeedd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants