Can the charge control feature from CalyxOS be merged?

[EmanuelLoos]

Hi, CalyxOS now has a charging control feature.
It seems to come from LineageOS.

It would be great if this could be merged/activated here as well. (If this is not already the case, not all devices seem to be supported so I would not know.)

[SkewedZeppelin]

No, I purposely disable this because I consider it broken.

[EmanuelLoos]

Why would it be broken? It seems to work for me on the FP4 with CalyxOS.

[SkewedZeppelin]

These charge control features can get into a state where the charge controller no longer allows the device to charge, even when in a critically low state.

It is a known issue on many devices, eg.: https://github.com/VR-25/acc#warnings

I'm not going to ship a feature that can destroy a user's device.

[EmanuelLoos]

How about only enabling it for devices, where the charge controller is known to work without such issues, then?

An automatic shutdown when the battery reaches a certain percentage would also help prevent this issue where there are faulty PMICs.

Removable batteries can be easily recharged and/or replaced.

A warning would be another idea. The feature could also be hidden in the developer options.

[ghost]

I know this is closed but figured id take a break from lurking and add some additional context. The charging control feature in calyx is semi broken and/or lacking features. The current setup for it as confirmed on my family members pixel 6a is that it sets up a time to delay charging until full. So if you plug in after 10pm it would in theory reach a full charge by whatever time you set in the morning. Even then imo its broken because if you plug in before the time enabled it still pushes near fully charged and hard to tell where the limit to delay is or if its being honored.

This does NOT stop full charging in general where you can limit it to like 90 or 85% etc.

On some lineage builds it has the setting to actually limit the charge % but thats another story and this feature is missing in calyx charging setting. This was specifically directed to calyx experience with latest builds.

Figured this detail is worth mentioning for people coming to this in the future. This is as of dec 8 2023 and could very well be fixed in the future but currently its not really useful.

[SkewedZeppelin]

On some lineage builds it has the setting to actually limit the charge %

It isn't missing in Calyx, it depends on whether the controller supports it, and not all Pixels do.