-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for longer passwords #27
Comments
Indeed. |
I might get to work on this I suppose as a good first issue, can't go wrong, how should one go around testing this, do I need to emulate DivestOS or use a real device with DivestOS and build it then run it on it to do the tests ? Is there a dev guide in the wiki ? Or should we try to write one for the DivestOS community so more things can be done by the community and maintainers like you can focus on harder issues or design for the future features of DivestOS ? |
@AkechiShiro
This is a one liner in f/w/b afaik. Some older branches may need a change in
Settings too.
See here how GrapheneOS does it:
GrapheneOS/platform_frameworks_base@63da3a2
|
@SkewedZeppelin thanks, but I need to make the changes upstream ? I don't understand where this exact line is for DivestOS, I'm looking at the manifests and most are cloning LineageOS or GrapheneOS GitLab/GitHub projects. |
DivestOS is a monorepo of scripts and patches that apply onto upstream.
For a change like this, I'd add a sed line to all the Patch.sh scripts.
|
So I had a look I have to patch every Scripts/<LOS/Common>/Patch.sh file with a higher limit for password length just like you've mentionned the GrapheneOS for instance. Probably the same sed line can be copied inside them |
I've done a PR, please review it when you have the time to do so @SkewedZeppelin, thanks for your help, I've backported the sed to all LineageOS |
Security Improvement Feature.
The text was updated successfully, but these errors were encountered: