Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for longer passwords #27

Closed
MarkCyberSecDev93 opened this issue Jan 12, 2022 · 7 comments
Closed

Add support for longer passwords #27

MarkCyberSecDev93 opened this issue Jan 12, 2022 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MarkCyberSecDev93
Copy link

Security Improvement Feature.

@SkewedZeppelin SkewedZeppelin changed the title Add Support for longer passwords by default (64 characters instead of 16) without requiring a device manager Add support for longer passwords Jan 12, 2022
@SkewedZeppelin SkewedZeppelin added enhancement New feature or request good first issue Good for newcomers labels Jan 12, 2022
@SkewedZeppelin
Copy link
Member

Indeed.
This was implemented in the past, but I dropped it during the vendor overhaul back in 2019 or so.
It does need to be added back.

@AkechiShiro
Copy link

I might get to work on this I suppose as a good first issue, can't go wrong, how should one go around testing this, do I need to emulate DivestOS or use a real device with DivestOS and build it then run it on it to do the tests ? Is there a dev guide in the wiki ? Or should we try to write one for the DivestOS community so more things can be done by the community and maintainers like you can focus on harder issues or design for the future features of DivestOS ?

@SkewedZeppelin
Copy link
Member

SkewedZeppelin commented Jun 6, 2022 via email

@AkechiShiro
Copy link

AkechiShiro commented Jun 6, 2022

@SkewedZeppelin thanks, but I need to make the changes upstream ? I don't understand where this exact line is for DivestOS, I'm looking at the manifests and most are cloning LineageOS or GrapheneOS GitLab/GitHub projects.
EDIT: What do you mean by f/w/b ?

@SkewedZeppelin
Copy link
Member

SkewedZeppelin commented Jun 6, 2022 via email

@AkechiShiro
Copy link

AkechiShiro commented Jun 6, 2022

So I had a look I have to patch every Scripts/<LOS/Common>/Patch.sh file with a higher limit for password length just like you've mentionned the GrapheneOS for instance.

Probably the same sed line can be copied inside them

@AkechiShiro
Copy link

AkechiShiro commented Jun 6, 2022

I've done a PR, please review it when you have the time to do so @SkewedZeppelin, thanks for your help, I've backported the sed to all LineageOS Patch.sh scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

3 participants