Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with heroku-push #126

Closed
doriczapari opened this issue Sep 11, 2014 · 5 comments
Closed

Problems with heroku-push #126

doriczapari opened this issue Sep 11, 2014 · 5 comments

Comments

@doriczapari
Copy link
Contributor

  1. Looks like heroku-push ignores the .gitignore file, and pushes local-settings.py.
    We solved this by putting all the settings in settings.py and got rid of local-settings.py.
  2. It doesn't trigger the creation of a Postgres database on Heroku. We had to do this manually.
@kampfschlaefer
Copy link
Contributor

When you "get rid" of a local settings file, you will push your local settings to heroku. Well, there are several reasons why these are called local settings. One of them is that certain settings are related to security and thus should not be checked into version controls and shouldn't be the same on different instances. For example the SECRET_KEY setting is something to be set on each instance separately.

In short: The problem with heroku-push should be fixed with heroku-push, not with doing insecure deployments in this tutorial...

@bmispelon
Copy link
Contributor

@kampfschlaefer We ended up using os.getenv to pull sensitive information out of environment variables so there's no inherent insecurity.

@domenkozar
Copy link
Contributor

Didn't have a problem with this, otherwise heroku would want to use sqlite database.

@mrzechonek
Copy link

spooky/heroku-push@5d558de can be fixed, but the plugin still sucks

@bmispelon
Copy link
Contributor

After a day of using heroku push here at the Warsaw workshop I haven't seen the error pop up again.

There must have been a concurrent issue that created this problem, so I'll close this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants