Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Django ORM": User vs. user is confusing #215

Closed
encukou opened this issue Dec 6, 2014 · 8 comments
Closed

"Django ORM": User vs. user is confusing #215

encukou opened this issue Dec 6, 2014 · 8 comments

Comments

@encukou
Copy link
Contributor

encukou commented Dec 6, 2014

Either case-sensitivity needs to be pointed out, or the user variable could just be renamed to e.g. me

@encukou encukou changed the title "Django ORM" User vs. user is confusing "Django ORM": User vs. user is confusing Dec 6, 2014
@bmispelon
Copy link
Contributor

I think it makes sense to have the variable called me.

@olasitarska
Copy link
Member

Always when I see an example like that after Django Girls workshop, I think that it's really obvious that this is confusing. It is sooo hard to put yourself in to beginner's perspective..

Thanks @encukou! Pull Request is really welcome!

@miclovich
Copy link

I noticed this in some workshops...students always did something like

User = User.objects.get(username="some_username")

Nice save!

@alvynmcq
Copy link
Contributor

I would be happy to change the user variable to a variable named me.

@bmispelon
Copy link
Contributor

@alvynmcq We'd love to have your contribution too!

The file to change is https://github.com/DjangoGirls/tutorial/blob/master/django_orm/README.md. You should be able to just use Github's online editor (the "edit" icon on the top right) to create the pull request.

Thanks!

@alvynmcq
Copy link
Contributor

@bmispelon I have created the pull request

@bmispelon
Copy link
Contributor

Fixed with #218.

Thank you very much, @alvynmcq

@encukou
Copy link
Contributor Author

encukou commented Dec 10, 2014

Thanks indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants