Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for inverting a complex matrix #51

Open
mmtrebuchet opened this issue Jul 10, 2016 · 1 comment
Open

Allow for inverting a complex matrix #51

mmtrebuchet opened this issue Jul 10, 2016 · 1 comment

Comments

@mmtrebuchet
Copy link

I see that invert is "Currently only defined for general real matrices". I don't have a good linear algebra intuition, and I can't see why the invert() function in linalg.d isn't capable of handling complex arguments. Everything I've seen suggests that ZGETRF and ZGETRI should invert a complex matrix. Is there something I'm missing?

@kyllingstad
Copy link
Member

To be honest, I don't know. I would guess that I had some reason to put the !scid.core.traits.isComplex!T constraint on the function at the time, but it's so many years ago that I don't remember anymore. And I agree, at a quick glance it does seem like it should work with complex types. If you confirm that this is the case, a pull request (with a unittest) that removes the comment and the constraint would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants