Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Phone doesn't show up #45

Open
Seppily opened this issue Apr 1, 2021 · 32 comments
Open

[BUG] Phone doesn't show up #45

Seppily opened this issue Apr 1, 2021 · 32 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Projects

Comments

@Seppily
Copy link

Seppily commented Apr 1, 2021

Describe the bug
When I press F1 the map gets big and nothing more happen, there no errors in the consol

To Reproduce
Steps to reproduce the behavior:

  1. F1
  2. Map gets big

Expected behavior
Map gets big

Screenshots
image

FiVEM(please complete the following information):

  • SaltyChat

Additional context

@Seppily Seppily added the bug Something isn't working label Apr 1, 2021
@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

Hey @Seppily,
Did you compile the phone yourself or used one of the releses

@HezimX
Copy link

HezimX commented Apr 1, 2021

i get this error with the new release

error

@Seppily
Copy link
Author

Seppily commented Apr 1, 2021

Hey @Seppily,
Did you compile the phone yourself or used one of the releses

I used your release...

@DmACKGL DmACKGL added this to To do in Bugs via automation Apr 1, 2021
@DmACKGL DmACKGL moved this from To do to In progress in Bugs Apr 1, 2021
@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

Hey everyone,

This error is from #26, I'm to check it right now sorry for the issues.

i get this error with the new release

error

Hey @Seppily,
Did you compile the phone yourself or used one of the releses

I used your release...

Let me Fix the error above and release it so we can try again.

Thanks everyone for the help!

This was referenced Apr 1, 2021
@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

@Seppily @HezimX
Can you guys try this artifact and tell me if it works? it works for me.
https://github.com/DmACKGL/GCPhone-Rewritten/suites/2401953579/artifacts/51103261

@HezimX
Copy link

HezimX commented Apr 1, 2021

gonna try now

@Seppily
Copy link
Author

Seppily commented Apr 1, 2021

@Seppily @HezimX
Can you guys try this artifact and tell me if it works? it works for me.
https://github.com/DmACKGL/GCPhone-Rewritten/suites/2401953579/artifacts/51103261

Doesn't work for me...

@HezimX
Copy link

HezimX commented Apr 1, 2021

@Seppily @HezimX
Can you guys try this artifact and tell me if it works? it works for me.
https://github.com/DmACKGL/GCPhone-Rewritten/suites/2401953579/artifacts/51103261

dident work

@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

@HezimX
Copy link

HezimX commented Apr 1, 2021

@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

@HezimX Try turning off the server, delete the cache folder, removing the gcphone folder and use this instead
https://github.com/DmACKGL/GCPhone-Rewritten/releases/tag/v1.2.5

@HezimX
Copy link

HezimX commented Apr 1, 2021

k

@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

@HezimX I'm uploading a new release now, for some reason the past release didn't get the latest fixes

@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

@HezimX
Copy link

HezimX commented Apr 1, 2021

@HezimX
Copy link

HezimX commented Apr 1, 2021

yep error gone and phone works gg :)

@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

Good to hear, what about you @Seppily

@Seppily
Copy link
Author

Seppily commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

@HezimX
Copy link

HezimX commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

@Seppily
Copy link
Author

Seppily commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

Okay works now! But when I recieve a new message, I ain't get an Notification... :(

@HezimX
Copy link

HezimX commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

Okay works now! But when I recieve a new message, I ain't get an Notification... :(

have you enable it in config?

@Seppily
Copy link
Author

Seppily commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

Okay works now! But when I recieve a new message, I ain't get an Notification... :(

have you enable it in config?

You mean "Config.ShowNumberNotification"?

@HezimX
Copy link

HezimX commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

Okay works now! But when I recieve a new message, I ain't get an Notification... :(

have you enable it in config?

You mean "Config.ShowNumberNotification"?

yes try it out

@Seppily
Copy link
Author

Seppily commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

Okay works now! But when I recieve a new message, I ain't get an Notification... :(

have you enable it in config?

You mean "Config.ShowNumberNotification"?

yes try it out

Still don't work...

@HezimX
Copy link

HezimX commented Apr 1, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

Okay works now! But when I recieve a new message, I ain't get an Notification... :(

have you enable it in config?

You mean "Config.ShowNumberNotification"?

yes try it out

Still don't work...

yep can confirm notification dont work

@DmACKGL
Copy link
Owner

DmACKGL commented Apr 1, 2021

Probably it's this #35

@DmACKGL DmACKGL added the good first issue Good for newcomers label Apr 2, 2021
@Seppily
Copy link
Author

Seppily commented Apr 2, 2021

Good to hear, what about you @Seppily

Phone works, but the map turns still big...

(SetBigmapActive) turn it off in client.lua

Okay works now! But when I recieve a new message, I ain't get an Notification... :(

have you enable it in config?

You mean "Config.ShowNumberNotification"?

yes try it out

Still don't work...

yep can confirm notification dont work

This error comes up :
image

@DmACKGL DmACKGL mentioned this issue Apr 2, 2021
@DmACKGL
Copy link
Owner

DmACKGL commented Apr 2, 2021

Hey everyone!

Sorry for the delay, I'm working on a fix right now. Can you guys check this version?
gcphone.zip

@zeroexoo
Copy link

zeroexoo commented Apr 2, 2021

Hey everyone!

Sorry for the delay, I'm working on a fix right now. Can you guys check this version?
gcphone.zip

This version seems to restart all NUI and fails to boot unfortunately, it threw some lua errors but the code there was fine so must have been due to something else
image
Line 436 ref;

RegisterNetEvent("gcPhone:waitingCall")
AddEventHandler("gcPhone:waitingCall", function(infoCall, initiator)
if initiator == true then
SendNUIMessage({event = 'waitingCall', infoCall = infoCall, initiator = initiator})
PhonePlayCall()
if menuIsOpen == false then
TooglePhone()
end
else if hasPhone then
SendNUIMessage({event = 'waitingCall', infoCall = infoCall, initiator = initiator})
end
end)
Ok i ate something, there is a space between else if on line 433

Which now produces this:
image

@Seppily
Copy link
Author

Seppily commented Apr 5, 2021

Hey everyone!

Sorry for the delay, I'm working on a fix right now. Can you guys check this version?
gcphone.zip

When you use SaltyChat, this will break it...

@JohnnyS
Copy link

JohnnyS commented Apr 5, 2021

The phone doesnt show up for me too and I am using the latest release, when it did work the menu was laggy and the keyboard wasnt showing up

@DmACKGL
Copy link
Owner

DmACKGL commented Apr 8, 2021

Hey Everyone,

This week I had a lot of work, that's why I didn't update the resource, I hope I'll return to development next week if everything goes as planned. So sorry.

All forks and pull request fixing problems are COMPLETELY welcome (and pls do, that's the idea of having an open-source project, so everyone can help to improve the resource)

(Copy paste of #67)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Bugs
In progress
Development

No branches or pull requests

5 participants