Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Create pck function is broken in 1.3.1 #5

Closed
AG-w opened this issue Oct 10, 2023 · 4 comments
Closed

[Bug]: Create pck function is broken in 1.3.1 #5

AG-w opened this issue Oct 10, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@AG-w
Copy link

AG-w commented Oct 10, 2023

Commit or version

1.3.1

On which operating systems the error occurs

Windows

Issue description

When you click "Pack or Embed folder", the program just frozen and do nothing

go back to 1.3.0 and it works fine

Steps to reproduce

  1. click "Pack or Embed folder"
  2. stuck at empty progress bar forever
@AG-w AG-w added the bug Something isn't working label Oct 10, 2023
@DmitriySalnikov
Copy link
Owner

I can only get errors if I don't delete the old files before updating.
image
But I don't have any errors if I use the clean version 1.3.1

@AG-w
Copy link
Author

AG-w commented Oct 10, 2023

so after I use 1.3.0 to pack a pck file, 1.3.1 no longer frozen at progress bar

I noticed you added a progress bar here, but there's no progress bar in 1.3.0
2ec24ae#diff-b6a8b961aeb93b8aad9caab9c75941d3590510c5dec91e3b8c024000c6e51c54

This is just my assumption
what if you use Create pck function for the first time, that FolderPath never get initialized and it stuck at scanning empty path?

@DmitriySalnikov
Copy link
Owner

DmitriySalnikov commented Oct 10, 2023

it stuck at scanning empty path?

hmm, could be related to an empty path. But I've already spent a lot of time on the frozen progress bar 😅

but there's no progress bar in 1.3.0

The progress bar was used in 1.3.0 when specifying the path, as it is now. It's just that its implementation was in the PCK creation window itself.

public void SetFolderPath(string path)

1.3.0
image

1.3.1 (it is necessary to return the counter of found files..)
image


stuck at scanning empty path

Confirmed.
Deleting the path line to the folder from the settings leads to an infinite progress bar and an error when closing it.
image

@DmitriySalnikov
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants