Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element.glow ignores {opacity: 0} #968

Closed
spookylukey opened this issue Jun 2, 2015 · 3 comments
Closed

Element.glow ignores {opacity: 0} #968

spookylukey opened this issue Jun 2, 2015 · 3 comments

Comments

@spookylukey
Copy link

Element.glow({opacity: 0}) (which is useful in the context of later animating the glow) behaves the same as Element.glow({}). It's easy to see why:

https://github.com/DmitryBaranovskiy/raphael/blob/master/raphael.js#L4185

opacity: glow.opacity || .5,

It should instead be checking for something like glow.opacity == null

@spookylukey
Copy link
Author

Actually I think it should be:

opacity: glow.opacity === undefined ? 0.5 : glow.opacity

@GoToLoop
Copy link

GoToLoop commented Jun 2, 2015

Another alternative: opacity: glow.opacity == null? .5 : glow.opacity;
It catches both null & undefined in the same check! :P

@tomasAlabes
Copy link
Collaborator

f7744d0 fixes this.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants