We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element.glow({opacity: 0}) (which is useful in the context of later animating the glow) behaves the same as Element.glow({}). It's easy to see why:
Element.glow({opacity: 0})
Element.glow({})
https://github.com/DmitryBaranovskiy/raphael/blob/master/raphael.js#L4185
opacity: glow.opacity || .5,
It should instead be checking for something like glow.opacity == null
glow.opacity == null
The text was updated successfully, but these errors were encountered:
Actually I think it should be:
opacity: glow.opacity === undefined ? 0.5 : glow.opacity
Sorry, something went wrong.
Another alternative: opacity: glow.opacity == null? .5 : glow.opacity; It catches both null & undefined in the same check! :P
opacity: glow.opacity == null? .5 : glow.opacity;
null
undefined
f7744d0 fixes this. Thanks!
No branches or pull requests
Element.glow({opacity: 0})
(which is useful in the context of later animating the glow) behaves the same asElement.glow({})
. It's easy to see why:https://github.com/DmitryBaranovskiy/raphael/blob/master/raphael.js#L4185
It should instead be checking for something like
glow.opacity == null
The text was updated successfully, but these errors were encountered: