Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move otkafka/processor out of core (close #155) #156

Merged
merged 2 commits into from Jul 27, 2021
Merged

refactor: move otkafka/processor out of core (close #155) #156

merged 2 commits into from Jul 27, 2021

Conversation

GGXXLL
Copy link
Contributor

@GGXXLL GGXXLL commented Jul 20, 2021

move to core-processor

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #156 (b41b05c) into master (affda16) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   79.98%   79.75%   -0.23%     
==========================================
  Files          94       92       -2     
  Lines        3872     3730     -142     
==========================================
- Hits         3097     2975     -122     
+ Misses        554      544      -10     
+ Partials      221      211      -10     
Impacted Files Coverage Δ
config/watcher/file.go 58.13% <0.00%> (-4.66%) ⬇️
dtx/sagas/mysqlstore/mysql_store.go 84.14% <0.00%> (-3.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update affda16...b41b05c. Read the comment docs.

@Reasno
Copy link
Member

Reasno commented Jul 20, 2021

why move?

@GGXXLL
Copy link
Contributor Author

GGXXLL commented Jul 20, 2021

why move?

Processor is a small module.
If the processor is modified, the whole package of core is not required to follow the release.

@Reasno
Copy link
Member

Reasno commented Jul 20, 2021

Seeing this is a huge breaking change, I am gonna hold on this removal until a major
release.

@Reasno Reasno merged commit 5aef315 into DoNewsCode:master Jul 27, 2021
@GGXXLL GGXXLL deleted the moveout-processor branch July 28, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants