Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move images/, js/, and css/ to assets/ path #28

Open
briandominick opened this issue May 24, 2021 · 0 comments
Open

Move images/, js/, and css/ to assets/ path #28

briandominick opened this issue May 24, 2021 · 0 comments
Labels
good first issue Good for newcomers Jekyll Involves working heavily with or extending Jekyll SSG
Milestone

Comments

@briandominick
Copy link
Contributor

The conventional way to package a Jekyll theme (and maybe the required way to do it as a Ruby gem?) is as follows:

├── _layouts/
├── _includes/
├── assets/
│   ├── css/
│   ├── images/
│   └── js/
├── _config.yml
├── asciidocsy.gempsec
├── Gemfile
└── README.md

You won't catch me using Markdown for a Readme in this lifetime, but the rest seems worth sticking to. This is basically a deprecation notice on the lack of a base directory assets/. I did this originally because LiquiDoc Ops had a concept of assets as well, and I did not want them to get confused. (Additionally, on some level it bothers me to call image, JS, and CSS files "assets" but exclude template files -- this could just be me.) I believe the concept of content assets is coming out of LDOps anyway, so it just makes good sense to standardize around this method and call the site files "assets".

@briandominick briandominick added good first issue Good for newcomers Jekyll Involves working heavily with or extending Jekyll SSG labels May 24, 2021
@briandominick briandominick added this to the 0.2.0 milestone May 24, 2021
This was referenced May 25, 2021
@briandominick briandominick removed this from To do in AsciiDocsy Priorities May 25, 2021
@briandominick briandominick modified the milestones: 0.2.0, 0.3.0 Jul 24, 2021
@briandominick briandominick moved this from To do to In progress in AsciiDocsy Priorities Sep 12, 2021
@briandominick briandominick moved this from In progress to Under review in AsciiDocsy Priorities Sep 21, 2021
@briandominick briandominick moved this from Under review to Merged in AsciiDocsy Priorities Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Jekyll Involves working heavily with or extending Jekyll SSG
Projects
Development

No branches or pull requests

1 participant