Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make select prompt disabled by default #39

Merged
merged 1 commit into from Feb 8, 2016
Merged

Make select prompt disabled by default #39

merged 1 commit into from Feb 8, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2016

Or should it be enabled by default, and optionally disabled?

@@ -34,9 +34,15 @@ export default Component.extend({
options = w(options);
}

if (get(this, 'promptIsSelectable') == null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using isBlank?

@poteto
Copy link
Collaborator

poteto commented Feb 8, 2016

@homu r+

poteto added a commit that referenced this pull request Feb 8, 2016
@poteto poteto merged commit 4c68cd8 into DavyJonesLocker:master Feb 8, 2016
@homu
Copy link
Contributor

homu commented Feb 8, 2016

📌 Commit bf8a92b has been approved by poteto

@ghost ghost deleted the prompt-disabled-by-default branch February 8, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants