Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Improve 'offloader.js' example #297

Open
Gesh4o opened this issue Feb 24, 2019 · 2 comments
Open

[Suggestion] Improve 'offloader.js' example #297

Gesh4o opened this issue Feb 24, 2019 · 2 comments

Comments

@Gesh4o
Copy link

Gesh4o commented Feb 24, 2019

Hello doc,

First of all - I am really grateful for having all of your libraries up there - you save all of us a lot of time energy and head bashing - so thank you!

I am new to the steam api ecosystem and I am trying to work with all the perks and quirks of it. I used your demo code in offloader.js (https://github.com/DoctorMcKay/node-steam-tradeoffer-manager/blob/master/examples/offloader.js) to build my very first steam bot and sometimes I was not able to login as my console was prompted for a steam guard code when it was already given in the loginOptions. After little research I found out that it is connected to: DoctorMcKay/node-steam-user#189.

Could we add something like this in the example:
`steamUser.on("steamGuard", function(domain, callback, lastCodeWrong) {

console.log("Steam Guard code needed from mobile (main bot)");

if(lastCodeWrong) {
    console.log("Last code wrong, try again!");
    setTimeout(function() {
        console.log(SteamTotp.getAuthCode("shared_secret"));                      
        callback(SteamTotp.getAuthCode("shared_secret"));
    }, 30000);
}

});
`

This is a solution provided from the issue above. What do you think about my suggestion?
I can make a pull request if you want.

@Gesh4o
Copy link
Author

Gesh4o commented Apr 9, 2019

Closing because of lack of response.

@Gesh4o Gesh4o closed this as completed Apr 9, 2019
@DoctorMcKay DoctorMcKay reopened this Apr 9, 2019
@DoctorMcKay
Copy link
Owner

I don't think this needs to be closed. I haven't responded because this has been fairly low on my priority list, not because I don't think it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants