Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSteamGuardDetails() gives false info #51

Closed
npabisz opened this issue Jan 13, 2016 · 5 comments
Closed

getSteamGuardDetails() gives false info #51

npabisz opened this issue Jan 13, 2016 · 5 comments
Labels

Comments

@npabisz
Copy link

npabisz commented Jan 13, 2016

If there is 2fa enabled on account and you login it having no auth file getSteamGuardDetails() returns canTrade equal to false based on steam guard enabled time on this machine, but if you have mobile auth you can freely trade on new machines having secret keys? So it gives false info, am I right?

@Ne3tCode
Copy link
Contributor

I can confirm false-negative result if the Steam Guard was activated before Steam began to remember the date of activation. Example:
SteamUser.getSteamGuardDetails() result:

enabled: true
enabledTime: 2012-12-21 18:29:57 // can be 'null'
machineTime: null
canTrade: false // WRONG!

Raw data:

{
  "is_steamguard_enabled": true,
  "timestamp_steamguard_enabled": 1356103797, // can be '0'
  "deprecated_newauthentication": [],
  "deprecated_machine_name_userchosen": "",
  "deprecated_timestamp_machine_steamguard_enabled": 0,
  "deprecated_authentication_exists_from_geoloc_before_mintime": null,
  "deprecated_machine_id": <redacted>,
  "session_data": [
    {
      "machine_id": <redacted>,
      "machine_name_userchosen": "",
      "timestamp_machine_steamguard_enabled": 0,
      "authentication_exists_from_geoloc_before_mintime": null,
      "newauthentication": [],
      "authentication_exists_from_same_ip_before_mintime": null,
      "public_ipv4": <redacted>
    }
  ],
  "is_twofactor_enabled": true,
  "timestamp_twofactor_enabled": 1449281153,
  "is_phone_verified": null
}

@Ne3tCode
Copy link
Contributor

Ne3tCode commented Mar 1, 2016

Not fixed. Incorrect result for:
timestamp_steamguard_enabled == 0
or
2FA disabled or less than 7 days and timestamp_machine_steamguard_enabled == 0

@DoctorMcKay
Copy link
Owner

If it's 0, does that always mean that it was enabled before they started tracking?

@Ne3tCode
Copy link
Contributor

Ne3tCode commented Mar 1, 2016

I think so. I dont know what result for disabled SteamGuard.

@DoctorMcKay
Copy link
Owner

I ask (and am hesitant to change it) as I've seen a value of 0 in timestamp_machine_steamguard_enabled when the sentry is brand-new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants