Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets base url option #25

Closed
MoOx opened this issue Mar 14, 2013 · 5 comments
Closed

Add assets base url option #25

MoOx opened this issue Mar 14, 2013 · 5 comments

Comments

@MoOx
Copy link
Contributor

MoOx commented Mar 14, 2013

To handle to base url of the templates assets, an option is required IMO.

@MoOx
Copy link
Contributor Author

MoOx commented Mar 14, 2013

(I just see that the template is copied by default, don't know if it change something for my request :) ).

@darcyclarke
Copy link
Member

Right now wrench does this for us based on the template url passed in (as you saw).

The only problem with this implementation right now is that wrench.copyDirSyncRecursive(template_dir, output_dir); (https://github.com/darcyclarke/DSS/blob/master/tasks/DSS.js#L417) also includes .mustache files in the output directory.

This is messy because we don't need those files after we've generated the documentation. Not sure if wrench has any way of excluding certain types of files when doing a .copy. If not, we may need to write our own method of cloning the files and assets inside the template directory and exclude .mustache files.

@MoOx
Copy link
Contributor Author

MoOx commented Mar 14, 2013

Maybe we can use something like assemble under the hood ?

@MoOx
Copy link
Contributor Author

MoOx commented Mar 14, 2013

Or just embed the grunt-contrib-copy task & use it with our own filters.

@darcyclarke
Copy link
Member

I think, again, that the current work already addresses this issue, so I'm going to close this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants