Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing modal - after modal is closed new overlay is created #3504

Closed
Voyteck opened this issue Aug 12, 2016 · 2 comments
Closed

Closing modal - after modal is closed new overlay is created #3504

Voyteck opened this issue Aug 12, 2016 · 2 comments

Comments

@Voyteck
Copy link

Voyteck commented Aug 12, 2016

When closing modal a new overlay is created right after closing animation is completed. This overaly has next index number at the end of id.
Interesting is that it is created after the animation is finished, so it can be destroyed only by binding to the close button destroying method delayed by setTimeout() function - workaround code below:

$('...').leanModal({
   complete: setTimeout(function() { $(".lean-overlay").remove(); })
});

As per now unfortunatelly "complete" callback also works incorrectly - so the above workaround will work only after fixing that (#3503) or the setTimout() code needs to be put somewhere else.

@jenwebb
Copy link

jenwebb commented Aug 24, 2016

How are we doing with this? Will there be a fix to modals anytime soon?

@fega
Copy link

fega commented Apr 6, 2017

leanModal is now deprecated.

@fega fega closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants