Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6669 - Remove the css implementation from the global HTML button element #6671

Closed
wants to merge 1 commit into from

Conversation

Nemila
Copy link

@Nemila Nemila commented Sep 11, 2022

  1. The styling of the button should be in _buttons.scss not in _forms.scss .
  2. _button.scss already have a :focus state.
  3. The styling shouldn't be applied to the global HTML button element and should instead be applied to the .btn class.

Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

1/ The styling of the button should be in _buttons.scss not in _forms.scss
2/ _button.scss already have a ":focus" state
3/ The styling shouldn't be applied ot the global HTML Button element and
should instead be applied to the .btn class.
@Nemila Nemila closed this by deleting the head repository Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant