Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome books: with ES6 #1

Merged
merged 2 commits into from Oct 4, 2022
Merged

Awesome books: with ES6 #1

merged 2 commits into from Oct 4, 2022

Conversation

Doheera-kosi
Copy link
Owner

In this milestone the following activities were carried out:

  • Created a new directory and initialize it with git.

  • Use npm init -y command to create package.json file.

  • Create the entry point for your JavaScript code called index.js

  • Create an index.css file for your styles.

  • Create the main index.html file. Link your index.js and index.css files there.

  • Create a directory called modules.

  • Use ES6 syntax.

  • Divided the code into modules.

  • Refactored methods and functions to arrow functions.

  • Use let and const in the correct way.

  • Display the current date below the navigation bar.

  • Luxon library was use

  • Fix linters errors

General requirements

  • Make sure that there weren't linters errors
  • Correct usage of git and GitHub flow
  • Professional documentation practices applied

HTML/CSS requirements

  • Follow our list of the best practices for HTML & CSS

JavaScript requirements

  • Followed our list of best practices for JavaScript

@Doheera-kosi Doheera-kosi changed the title Update READMEmd Awesome books: with ES6 Oct 3, 2022
Copy link

@HAMMAS-SALEEM HAMMAS-SALEEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢 🥇 💯

success

Hey @Doheera-kosi 👋

Great work on implementing the requirements. Your project is complete. 😊
There is nothing else to say about your project. 👍

Highlights 🥇

✔️ Descriptive PR Title
✔️ Descriptive PR Summary
✔️ Following Github Flow
✔️ Following Requirements

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@@ -1,4 +1,4 @@
import { pushItems } from './modules/pushItems.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional]

  • Your page should not reload after adding a book. Kindly fix this issue 😊

@Doheera-kosi Doheera-kosi merged commit 68d7927 into main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants