Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps)!: update unified ecosystem dependencies #395

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix(deps)!: update unified ecosystem dependencies #395

merged 2 commits into from
Jan 30, 2024

Conversation

rfgamaral
Copy link
Member

@rfgamaral rfgamaral commented Aug 16, 2023 •
edited
Loading

Overview

Unified.js v11 has been released, and as you might know, unified is "a collective of 500+ free and open source packages that work with content as structured data (ASTs)".

This PR will take care of bumping all related peer dependencies to their latest major versions in one fell swoop. This is required because the latest versions have some breaking changes that affect us, and while some dependencies don't seem to cause any issues, it's best if we only use versions that were meant to work with each other.

Here's a list of all dependencies that we are using, and which ones have already been upgraded:

Dependencies

Edit tasklist title
Beta Give feedback Tasklist Dependencies, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. mdast-util-gfm-autolink-literal
    Options
  2. mdast-util-gfm-strikethrough
    Options
  3. micromark-extension-gfm-autolink-literal
    Options
  4. micromark-extension-gfm-strikethrough
    Options
  5. react-markdown
    Options
  6. rehype-minify-whitespace
    Options
  7. rehype-raw
    Options
  8. rehype-stringify
    Options
  9. rehype
    Options
  10. remark-breaks
    Options
  11. remark-gfm
    Options
  12. remark-rehype
    Options
  13. remark
    Options
  14. unified
    Options
  15. unist-util-is
    Options
  16. unist-util-remove
    Options
  17. unist-util-visit
    Options
Loading

PR Checklist

Test plan

  • Open the preview Storybook deployed to Netlify
  • Open the Rich-text → Functions → Commands story
  • Click the insertMarkdownContent button
    • Observe that the editor content is rendered as expected
  • Use the content control input, and type whatever Markdown you want
    • Observe that the editor content is always rendered as expected

Note

We are only using Unified in the HTML serializer (for now), so changes in this PR do not affect the "Markdown Output" window, only the "Typist Editor" window (that is, Markdown content that needs to be parsed into HTML to be fed into Tiptap).

@rfgamaral rfgamaral self-assigned this Aug 16, 2023
@netlify
Copy link

netlify bot commented Aug 16, 2023 •
edited
Loading

✅ Deploy Preview for doist-typist ready!

Name Link
🔨 Latest commit 39c939a
🔍 Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/65b8d35053b5690008a75c10
😎 Deploy Preview https://deploy-preview-395--doist-typist.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rfgamaral rfgamaral added the 🙋 Ask PR Used for PRs that need a review before merging. label Aug 17, 2023
This was referenced Aug 17, 2023
Closed
Closed
Closed
Closed
This was referenced Aug 24, 2023
Merged
Closed
Closed
@rfgamaral rfgamaral force-pushed the ricardo/upgrade-unified-ecosystem branch from 67a1310 to 94a7f0f Compare August 24, 2023 08:53
This was referenced Aug 29, 2023
Closed
Closed
Closed
@rfgamaral rfgamaral force-pushed the ricardo/upgrade-unified-ecosystem branch from 94a7f0f to 52a95a5 Compare August 29, 2023 22:05
@rfgamaral rfgamaral mentioned this pull request Aug 31, 2023
Closed
1 task
This was referenced Sep 25, 2023
Closed
Closed
Closed
Closed
@rfgamaral rfgamaral mentioned this pull request Oct 3, 2023
Closed
1 task
@rfgamaral rfgamaral force-pushed the ricardo/upgrade-unified-ecosystem branch 4 times, most recently from 5c38572 to 344dc0c Compare October 3, 2023 18:49
@rfgamaral rfgamaral removed their assignment Nov 21, 2023
This was referenced Jan 11, 2024
Closed
Closed
Closed
@rfgamaral rfgamaral force-pushed the ricardo/upgrade-unified-ecosystem branch from 344dc0c to c545d3e Compare January 18, 2024 13:38
@rfgamaral rfgamaral force-pushed the ricardo/upgrade-unified-ecosystem branch from c545d3e to d47aeab Compare January 18, 2024 13:43
@rfgamaral rfgamaral mentioned this pull request Jan 18, 2024
Closed
1 task
@rfgamaral rfgamaral force-pushed the ricardo/upgrade-unified-ecosystem branch 2 times, most recently from cb4a4a9 to af97716 Compare January 23, 2024 10:37
@rfgamaral rfgamaral force-pushed the ricardo/upgrade-unified-ecosystem branch from 9ae49de to 39c939a Compare January 30, 2024 10:45
@rfgamaral rfgamaral marked this pull request as ready for review January 30, 2024 10:45
@rfgamaral rfgamaral self-assigned this Jan 30, 2024
@rfgamaral rfgamaral added ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green. and removed 🙋 Ask PR Used for PRs that need a review before merging. labels Jan 30, 2024
@rfgamaral
Copy link
Member Author

Switching this to ship because we've been testing these changes in production for a few days now, and no issues have been reported so far.

@rfgamaral rfgamaral merged commit e97ad83 into main Jan 30, 2024
11 checks passed
@rfgamaral rfgamaral deleted the ricardo/upgrade-unified-ecosystem branch January 30, 2024 10:48
doistbot added a commit that referenced this pull request Jan 30, 2024
@doistbot
chore(release): 4.0.0 [skip ci]
4345b2c 
## [4.0.0](v3.0.0...v4.0.0) (2024-01-30)

### ⚠ BREAKING CHANGES

* **deps:** update unified ecosystem dependencies (#395)

### Bug Fixes

* **deps:** update unified ecosystem dependencies ([#395](#395)) ([e97ad83](e97ad83))
@doistbot
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doistbot doistbot added the released Pull requests that have been released to production label Jan 30, 2024
@rfgamaral rfgamaral mentioned this pull request Mar 6, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rfgamaral rfgamaral

Labels
released Pull requests that have been released to production ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfgamaral @doistbot