refactor!: Use a wildcard export for ProseMirror model, state and view #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgamaral
added
the
⛴ Ship PR
rfgamaral
force-pushed
the
ricardo/refactor-prosemirror-exports
branch
from
76d05f0
to
b752f65
Compare
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
force-pushed
the
ricardo/refactor-prosemirror-exports
branch
from
b752f65
to
52e915e
Compare
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
More often than not, we need to import things from ProseMirror related packages on our consumer applications, and so far we've been exporting exactly what we need when needed. This slows us down a bit, because it forces us to do some work on Typist when something we need is not yet exported.
We (I discussed this with Pedro) decided that it would be best to remove this step in the workflow, and for that reason we will now start exporting everything in the
@tiptap/pm/*packages as wildcardProseMirror*exports.PR Checklist