fix(rich-text-link): Change openOnClick default to whenNotEditable
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgamaral
added
the
👀 Show PR
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
force-pushed
the
ricardo/change-link-defaults
branch
from
a85e66b
to
d13ab82
Compare
rfgamaral
force-pushed
the
ricardo/change-link-defaults
branch
from
d13ab82
to
3c292b5
Compare
rfgamaral
changed the title
openOnClick default to whenNotEditableopenOnClick default to whenNotEditable
doistbot
added a commit
that referenced
this pull request
Apr 15, 2024
## [6.0.2](v6.0.1...v6.0.2) (2024-04-15) ### Bug Fixes * **rich-text-link:** Change `openOnClick` default to `whenNotEditable` ([#744](#744)) ([db729d4](db729d4))
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The goal of this change is to provide sane defaults for Typist., and in this case we take advantage of a new
Linkoption in the latest Tiptap version where we can finally define that we want link clicks to NOT open when clicking them, but only when the editor is editable.Tip
This allows us to remove the
link: { openOnClick: false }configuration option that we pass to theRichTextKit.configure()call in most of our editor usages in both Todoist and Twist.PR Checklist
Test plan
Note
I've written a test plan, but this is still a
showPR because it's a very simple change.Rich-text → Defaultstorydoist.dev<space>doist.devtext