Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setVolume method on IoS side #288

Merged
merged 1 commit into from Sep 7, 2023
Merged

Implement setVolume method on IoS side #288

merged 1 commit into from Sep 7, 2023

Conversation

kbetl-dlb
Copy link
Contributor

No description provided.

@kbetl-dlb kbetl-dlb linked an issue Sep 7, 2023 that may be closed by this pull request
Add setVolume(p: Participant) for iOS #278
Open
@kbetl-dlb kbetl-dlb force-pushed the feature/set_volume_for_participant branch from 175e745 to e50af20 Compare September 7, 2023 11:39
graduad
graduad reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@graduad graduad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one comment.

example/ios/Podfile.lock Outdated Show resolved Hide resolved
@kbetl-dlb kbetl-dlb force-pushed the feature/set_volume_for_participant branch from e50af20 to f2096cb Compare September 7, 2023 12:55
@kbetl-dlb kbetl-dlb merged commit 0b3e15e into develop Sep 7, 2023
3 checks passed
@graduad graduad deleted the feature/set_volume_for_participant branch September 8, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graduad graduad graduad approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add setVolume(p: Participant) for iOS
2 participants
@kbetl-dlb @graduad