Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog link points to actual release, not proposed upgrade #15618

Closed
maxauvy opened this issue Dec 2, 2020 · 2 comments
Closed

Changelog link points to actual release, not proposed upgrade #15618

maxauvy opened this issue Dec 2, 2020 · 2 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@maxauvy
Copy link

maxauvy commented Dec 2, 2020

Bug

When going in the admin section to check for updates, if an update is proposed, I usually click the changelog link to see if there's something critical/urgent... with this update.
This leads to the "old changelog", that is to say the diff between 12.0.1 and 12.0.2, and not to the diff between 12.0.2 (installed version) and the 12.0.3 (proposed version).

Environment

  • Version: 12.0.3 (but present for several releases)
  • OS: Linux (Debian 10 "Buster" x64)
  • Web server: nginx/1.14.2
  • PHP: 7.3.19-1~deb10u1
  • Database: MariaDB 10.4.15
  • URL(s): mydomain.tld/admin/system/dolibarr.php?mainmenu=home&leftmenu=admintools_info

Expected and actual behavior

The "See changelog" link shoul point to the diff between installed version and proposed update, not to the diff related to a previous upgrade.

On the image here, the link points to https://raw.githubusercontent.com/Dolibarr/dolibarr/12.0.2/ChangeLog while I was hoping to parse https://raw.githubusercontent.com/Dolibarr/dolibarr/12.0.3/ChangeLog

image

Thanks all for this great tool btw <3

@maxauvy maxauvy added the Bug This is a bug (something does not work as expected) label Dec 2, 2020
@dolibit-ut
Copy link
Contributor

I can see.

I thought $newversion should solve that - but then it refers to changelog 8.0.6
?

@eldy
Copy link
Member

eldy commented Dec 3, 2020

The link "See ChangeLog" is the link to know what has changed in your current version. This is the expected behaviour but it is not clear so i pushed a fix.

@eldy eldy closed this as completed in ac29db9 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

3 participants