Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12.x V13.X decimal quantity in expense reports line on editline #16127

Closed
Arre8 opened this issue Feb 1, 2021 · 4 comments
Closed

V12.x V13.X decimal quantity in expense reports line on editline #16127

Arre8 opened this issue Feb 1, 2021 · 4 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@Arre8
Copy link

Arre8 commented Feb 1, 2021

Bug

quantity can be decimal in expens reports line on addnewline action but not on editline action

Environment

  • Version: tested V12.x V13.X
  • /expensereport/card.php

in action addnewline, the field is:
print '<input type="text" min="0" class="right maxwidth50" name="qty" value="'.dol_escape_htmltag($qty ? $qty : 1).'">'; // We must be able to enter decimal qty

-> in action editline:
print '<input type="number" min="0" class="right maxwidth50" name="qty" value="'.dol_escape_htmltag($line->qty).'" />';
should be
print '<input type="text" min="0" class="right maxwidth50" name="qty" value="'.dol_escape_htmltag($line->qty).'" />'; // We must be able to enter decimal qty

@Arre8 Arre8 added the Bug This is a bug (something does not work as expected) label Feb 1, 2021
@github-actions github-actions bot added the Issue Stale (automatic label) This issue is stale because it has been open 1 year with no activity. Remove this label to keep open label Feb 1, 2022
@manu-p
Copy link

manu-p commented Feb 2, 2022

Hi, is it still a bug? Has it been fixed?

@github-actions github-actions bot removed the Issue Stale (automatic label) This issue is stale because it has been open 1 year with no activity. Remove this label to keep open label Feb 2, 2022
@github-actions github-actions bot added the Issue Stale (automatic label) This issue is stale because it has been open 1 year with no activity. Remove this label to keep open label Feb 2, 2023
@manu-p
Copy link

manu-p commented Feb 3, 2023

Any news? See you next year! (or not) :-D

@github-actions github-actions bot removed the Issue Stale (automatic label) This issue is stale because it has been open 1 year with no activity. Remove this label to keep open label Feb 3, 2023
@priojk
Copy link
Contributor

priojk commented Feb 3, 2023

I think, this issue should be re-opened, IF it is still a bug. But is it indeed the case? Last year you just asked. It would be helpful to check in the current release and re-open only, if it is still relevant.

@Hystepik
Copy link
Contributor

It seems to be fixed so I close the issue in develop.
Feel free to reopen if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

4 participants