Regression: Takepos issue with cash method and dictionnaries

[loxK]

Bug

There is a mess in payment methods. First, in the dictionaries, changing a payment method's label has no visible effect (for any payment method):

Also, it has no visible effect on TakePos UI. Whatever is set in the dictionaries, the button always shows "Espèce" as the label.

Worst, for "Espèces" if the label value is not set to "cash", takepos will not accept the payment, complaining about bank account not set for that method. (also seen in the forum)

This was notices after upgrading from version 12 to 13, and it is still an issue in 14.0.1

I looked at the code, and it looks messy to me with many things like:

if ($paycode == 'LIQ') $paycode = 'CASH';
if ($paycode == 'CB')  $paycode = 'CB';
if ($paycode == 'CHQ') $paycode = 'CHEQUE';

	if ($paycode == 'LIQ') {
		$paycode = 'cash';

$paycode = $pay;
if ($pay == 'cash')   $paycode = 'LIQ'; // For backward compatibility
if ($pay == 'card')   $paycode = 'CB'; // For backward compatibility
if ($pay == 'cheque') $paycode = 'CHQ'; // For backward compatibility

Environment

• Version: 14.0.1, 13.0.4, develop
• OS: Ubuntu
• Web server: Apache, any version
• PHP: 7.4
• Database: MySQL
• URL(s): /htdocs/admin/dict.php?id=13 , /htdocs/takepos/index.php?idmenu=186&mainmenu=takepos&leftmenu=

Expected and actual behavior

Well, a label is a label, and it has a "code" to abstract its usage. The set labels should be used for payment method's labels in the UI, and changing it shouldn't affect core functionalities.

[github-actions]

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. This issue may be closed automatically by stale bot in 10 days (you should still be able to re-open it if required).