Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored Cross-site scripting (XSS) in product page #7727

Closed
prodigysml opened this issue Oct 27, 2017 · 5 comments
Closed

Stored Cross-site scripting (XSS) in product page #7727

prodigysml opened this issue Oct 27, 2017 · 5 comments
Labels
Issue Stale (automatic label) This issue is stale because it has been open 1 year with no activity. Remove this label to keep open

Comments

@prodigysml
Copy link

Bug

Stored Cross-site scripting (XSS) using product page, bypassing XSS detection

Environment

  • Version: 6.0.2
  • OS: Ubuntu
  • Web server: Apache
  • PHP: 7.0
  • Database: MySQL
  • URL(s): product/card.php?id=1929&mainmenu=home

Expected and actual behavior

Expected behaviour

XSS detector picks up on the payload and refuses to save it

Actual behaviour

XSS payload is saved with no interference from the detector. When visiting the page later, the payload executes.

Steps to reproduce the behavior

  1. Log into Dolibarr with a user who can edit the name of a product
  2. Choose a product (this products name will be changed FYI), and click on the modify details button
  3. Append the following payload to the product's current name: <iframe/src="data:text/html;&Tab;base64&Tab;,PGJvZHkgb25sb2FkPWFsZXJ0KDEpPg==">

Suggested implementation

Change the detector to now pick up on similar payloads (including this one)

@carnil
Copy link

carnil commented Feb 10, 2018

This issue was assigned CVE-2017-1000509.

@fgeek
Copy link

fgeek commented Feb 22, 2018

Has someone from development team verified this and are you planning to fix this vulnerability?

@atm-florian
Copy link
Contributor

Try on 7.0
Access refused by SQL/Script injection protection in main.inc.php (type=0 key=ref value=<iframe/src="data:text/html; base64 ,PGJvZHkgb25sb2FkPWFsZXJ0KDEpPg=="> page=/dolibarr/product/card.php)

@atm-florian
Copy link
Contributor

Issue should be close

@github-actions
Copy link

github-actions bot commented Mar 2, 2020

This issue is stale because it has been open 1 year with no activity. If this is a bug, please comment to confirm it is still present on latest stable version. if this is a feature request, please comment to notify the request is still relevant and not yet covered by latest stable version. Without comment, this issue will be closed automatically by stale bot in 15 days.

@github-actions github-actions bot added the Issue Stale (automatic label) This issue is stale because it has been open 1 year with no activity. Remove this label to keep open label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue Stale (automatic label) This issue is stale because it has been open 1 year with no activity. Remove this label to keep open
Projects
None yet
Development

No branches or pull requests

4 participants