Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminal-notifier as a recommended/optional depency #25

Closed
TheHarcker opened this issue Apr 22, 2020 · 4 comments
Closed

Add terminal-notifier as a recommended/optional depency #25

TheHarcker opened this issue Apr 22, 2020 · 4 comments

Comments

@TheHarcker
Copy link

TheHarcker commented Apr 22, 2020

It would be nice if terminal-notifier would be listed as a (required/optional/recommended) dependency for brew to install along with autoupdate.

Will the above be impossible due to this only being a tap and not a full fledged formula?

If it is impossible, it would be nice to have a simple brew install terminal-notifier in the README.md

@DomT4
Copy link
Owner

DomT4 commented May 1, 2020

It would be nice if terminal-notifier would be listed as a (required/optional/recommended) dependency for brew to install along with autoupdate.

I've put a fair bit of thought into this over time. My thoughts have generally pooled into:

  • Would it be possible to rewrite the notification output to use system notifications without needing an external dependency to achieve this, without increasing the maintenance this project requires significantly?
  • Would it be prudent to ship my own bundled terminal-notifier.
  • If yes, how to achieve this without asking users to simply straight up trust me putting a binary blob on their system without doing anything nefarious. I never would and I know a chunk of people trust me because I used to be a core maintainer over at Homebrew before I left the project, but I also completely understand and empathise with people being wary of random people vendoring external dependencies.

@RogierdeRuijter
Copy link

RogierdeRuijter commented Jun 28, 2020

Would it be possible to rewrite the notification output to use system notifications without needing an external dependency to achieve this, without increasing the maintenance this project requires significantly?

@DomT4 Hi, the part you wrote above sparked my interest.

It seems to be possible to create a system notification from an AppleScript script. If we are able to run an AppleScript and get the clients system to trust this script, this might be doable.

Let me know what you think!

Source

@DomT4
Copy link
Owner

DomT4 commented Nov 17, 2020

6365cc0, f31a161, 8b12c22, e2b76a0, 6a084e3, 6bc10b3, 322bb03 together implements a new, experimental notification system that uses Applescript to execute and doesn't rely on or need any external dependencies. At the moment it only runs on macOS Big Sur, which is largely my way of testing it in a limited roll-out before turning it on for everyone. The applet is also codesigned, so should run on other macOS machines.

As with most brew-autoupdate changes to cause minimal disruption I haven't automatically pushed the change through to users locally; if you wanted to change to the new notification system on Big Sur you'd need to manually brew autoupdate --delete and then brew autoupdate --start again.

@DomT4
Copy link
Owner

DomT4 commented Apr 15, 2021

Folded into #43.

@DomT4 DomT4 closed this as completed Apr 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants