onAspectRatioChange not called when going from unset/false to set

[billneff79]

onAspectRatioChange is not being called when going from a falsey value to a truthy value, but is fired when going from a truthy value to another truthy value or to a falsey value.

Was that intentional or not? If not, it would be useful for our application to also fire onAspectRatioChanged when going from unset to set as we would like to update a preview of the crop that we are showing when the aspect ratio changes from freehand to a specific aspect ratio.

[sekoyo]

Thanks this isn't intentional and your way makes sense. I'm away with just a phone until the end of May though so won't be able to address this until then.

…

On Thu, 11 May 2017 at 12:10, Bill Neff ***@***.***> wrote: onAspectRatioChange is not being called when going from a falsey value to a truthy value, but is fired when going from a truthy value to another truthy value or to a falsey value. Was that intentional or not? If not, it would be useful for our application to also fire onAspectRatioChanged when going from unset to set as we would like to update a preview of the crop that we are showing when the aspect ratio changes from freehand to a specific aspect ratio. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#101>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuZ-h9lGBqVZ2WyewKmPLbljarifqdrks5r4ooVgaJpZM4NXfjN> .

[billneff79]

Thanks. Not a hurry. End of the moth would be great. On Thu, May 11, 2017 at 5:55 AM Dominic Tobias <notifications@github.com> wrote:

…

Thanks this isn't intentional and your way makes sense. I'm away with just a phone until the end of May though so won't be able to address this until then. On Thu, 11 May 2017 at 12:10, Bill Neff ***@***.***> wrote: > onAspectRatioChange is not being called when going from a falsey value to > a truthy value, but is fired when going from a truthy value to another > truthy value or to a falsey value. > > Was that intentional or not? If not, it would be useful for our > application to also fire onAspectRatioChanged when going from unset to set > as we would like to update a preview of the crop that we are showing when > the aspect ratio changes from freehand to a specific aspect ratio. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#101>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AAuZ-h9lGBqVZ2WyewKmPLbljarifqdrks5r4ooVgaJpZM4NXfjN > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#101 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP6gZDUPVGJF1GtNhDYfN563nefKTmqrks5r4tr4gaJpZM4NXfjN> .

[sekoyo]

Released in 2.0.5