"Maximum update depth exceeded" when clicking the image

[djorak]

I have been getting this error and it looks like it was introduced recently. At first I assumed it was an issue in my local setup, but I can reproduce it in the demo.

It seems to come from the fact that the onChange gets called in an infinite loop.

• Version: 6.0.7
• Steps to reproduce:
  1. open demo (Tried in Firefox and Chrome)
  2. upload an image
  3. click anywhere in the image
  4. notice React Error
• Error:

Invariant Violation
Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.

Note: rolling back to v6.0.5 fixes it.

[sekoyo]

Hi this should be fixed in 6.0.8 please give it a go

[djorak]

Thank you, 6.0.8 fixed it. 🙂

[sekoyo]

Great thanks for checking

[noashka]

Hello. I have the same problem. When I upload an image in the first time and trying change cropp size I have this error. I took example code from the demo folder
react 16.6
react-image-crop 6.0.11

But when I downgrade module version to 6.0.8 it works fine

[sekoyo]

@noashka thanks can you please let me know the dimensions of the image you tried and also the crop settings? And does it happen every time when you try to resize the crop?

I will take a look at it this evening

[noashka]

I used a simple jpeg image, 435x512px.
I used example code from the demo folder. I changed only module import.
If I use initial crop area, I get an error.
If I set new crop area, all works fine

[sekoyo]

Thanks @noashka, if you get a moment I'm curious if you get the same error on https://codesandbox.io/s/72py4jlll6

Edit: I've spotted one issue but not sure if it's the cause, anyway I'll try and repro later and fix the issue I spotted

[noashka]

@dominictobias yes, I get the same error

[sekoyo]

Thanks, interesting I can't actually replicate but I've seen it before but not sure what I did. I choose an image and then play around with moving and resizing and didn't manage to break it yet.

[sekoyo]

@noashka Please try 6.0.12 this issue should be fixed now. It was proving too problematic to try and fix/complete invalid aspect crops every component update/render, so I just fix/complete them if they are incorrect on image load

[noashka]

@dominictobias You've fixed it! Thank you for help!

[sekoyo]

Great thanks for checking

…

On Thu, 24 Jan 2019 at 11:03, Vadim ***@***.***> wrote: @dominictobias <https://github.com/DominicTobias> You've fixed it! Thank you for help! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#218 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuZ-poQ31IvaJQwT0aLGBYIgWHtrsSgks5vGZMfgaJpZM4YeCHZ> .