Allow nuding in multiple directions #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this 👍 Will test it in the next couple of days but looks good. Yeah I don't see an issue with using Set as you have |
This was referenced Aug 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you hold down multiple keys when nudging, the cropper will pick the most recently pressed key and use it for the nudge direction. This can make it confusing when attempting to crop towards a corner. This PR adds a new variable to the class called
keysDown(essentially a ref since it doesn't need to be state) which tracks the keys that are currently down. Then, when keydown is fired we can calculate the nudge based on all the keys which are down.The main question I have for you about this PR is my usage of
Setwhich I'm not sure if that is okay based on the browser support of this library. The mdn docs would seem to indicate that even IE11 supports theadd,has, anddeletemethods which is all that I needed to use for this PR. I assume then it's okay to use? If so, I'll need to fix the ESLint warning about Set not being defined.