Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited deepdep depth #41

Open
ErdaradunGaztea opened this issue Dec 20, 2021 · 0 comments
Open

Unlimited deepdep depth #41

ErdaradunGaztea opened this issue Dec 20, 2021 · 0 comments
Assignees
Labels
long term 📆 TODO long term maintenance 🔨 Code enhancements, tests and maintenance

Comments

@ErdaradunGaztea
Copy link
Collaborator

There should be a way to generate deepdep object for given package without depth limit. It would be intuitive to achieve this by using depth = Inf, but our current implementation disallow that. It would try to create an infinite-length numeric vector, which is... kinda impossible:

# R/deepdep.R line 58
for (level in 2:depth)

There are two ways to approach this: the simpler one would be to make this iteration conditional; the other -- to rewrite this code, perhaps more efficiently.

@ErdaradunGaztea ErdaradunGaztea added maintenance 🔨 Code enhancements, tests and maintenance long term 📆 TODO long term labels Dec 20, 2021
@ErdaradunGaztea ErdaradunGaztea added this to the deepdep v0.5.0 milestone Dec 20, 2021
@ErdaradunGaztea ErdaradunGaztea pinned this issue Dec 21, 2021
@ErdaradunGaztea ErdaradunGaztea self-assigned this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long term 📆 TODO long term maintenance 🔨 Code enhancements, tests and maintenance
Projects
None yet
Development

No branches or pull requests

1 participant