Refactor class based component to a functional component with hooks #4
Conversation
There was a problem hiding this comment.
Hi @Donard97 ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
- I recommend you to commit your changes more frequently so that they can be tracked easily and makes your repo more professional. 🙏
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| const handleEvent = (e) => { | ||
| setState({ ...state, ...calculate(state, e.target.name) }); | ||
| }; |
There was a problem hiding this comment.
- When an operator button is clicked multiple times consecutively, it throws an error on the browser. Even though you did a great job refactoring the Calculator component to a functional component, it is required that your app is free of error. Kindly add an error handling condition or method. 🙏
There was a problem hiding this comment.
Thank you for reviewing my project! I didn't do an error handling condition or method because I found the error. The function when the user presses an operation without having entered a number first return nothing was commented.
There was a problem hiding this comment.
STATUS: APROVED 🟢 👏
Hello @Donard97 ,
Your project is complete! There is nothing else to say other than... Great job 👏
Congratulations! 🎉
Now you can merge this branch and move on 🥇
HAPPY CODING AND GOOD LUCK WITH THE COMMING ONES 🤞 🍀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
I created this PR to check if our project was as requested.
This is the first project on React module. I created a calculator and in this milestone, I had to refactor the calculator component.
Project Requirement:
Feel free to review my project and let me know if there are any essential changes 💪 .