Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Problems when an address is specified with .onion #37

Closed
DonnchaC opened this issue Jul 29, 2016 · 0 comments
Closed

Problems when an address is specified with .onion #37

DonnchaC opened this issue Jul 29, 2016 · 0 comments
Labels

Comments

@DonnchaC
Copy link
Owner

OnionBalance fails when an instance address with the .onion extension is listoed in the config file. It fetches the correct descriptor but it does not successfully compare the onion addresses.

I had this config:

| - # ftp.debian.org via vwakviie2ienjx6t.onion
| key: private_keys/ftp.debian.org.key
| instances:
| - address: kpw6vrobjzz4yd7x.onion
| name: klecker-ftp.debian.org

And shortly after start up I would get
| [WARNING]: Received a descriptor with address kpw6vrobjzz4yd7x.onion that did not match any configured service instances.

Digging a little, suggests that onionbalance would try to set up things
and fetch the descriptor for kpw6vrobjzz4yd7x.onion. However, when it
was getting the descriptor, it ended up being confused about the .onion
extensioni. I added some log lines to descriptor.py's descriptor_received():

| [WARNING]: [weasel] iterating over configured services
| [WARNING]: [weasel] service <onionbalance.service.Service object at 0x7f03bff246d8>
| [WARNING]: [weasel] instance <onionbalance.instance.Instance object at 0x7f03bff24588>
| [WARNING]: [weasel] onion_address kpw6vrobjzz4yd7x.onion
| [WARNING]: [weasel] descriptor_onion_address kpw6vrobjzz4yd7x
^^^^^^^^^^ of course, == will fail between these.
| [WARNING]: Received a descriptor with address kpw6vrobjzz4yd7x.onion that did not match any configured service instances.

I suggest that onionbalance either handle .onion as address everywhere,
or that it reject them earlier.

Original ticket: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832821

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant