Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icons #1811

Merged
merged 13 commits into from
Nov 18, 2023
Merged

New Icons #1811

merged 13 commits into from
Nov 18, 2023

Conversation

onuronsekiz
Copy link
Contributor

I noticed most car and motorcycle brand icons are missing.
So here they are; 22 New Icons and 29 Appfilter Entries

  1. Algorithms
  2. Arabam
  3. My BMW (*)
  4. BMW Türkiye (*)
  5. Campu.eu
  6. My Dacia (**)
  7. Dacia Media Control (**)
  8. Fiat Yol Arkadaşım
  9. Harley Davidson
  10. Honda Bikes
  11. Honda Connect
  12. Mazda
  13. myChevrolet
  14. My Citroën
  15. MyFerrari
  16. myHyundai
  17. Kia Connect (***)
  18. Kia Fan (***)
  19. MyKia (***)
  20. MyKia Chile (***)
  21. Lexus Lounge (****)
  22. Lexus Connect (****)
  23. MyNISSAN (*****)
  24. Nissan Türkiye (*****)
  25. My Opel
  26. MyPeugeot
  27. SEAT Online
  28. Maruti Suzuki
  29. Yamaha Motor Malaysia

Algorithms
Arabam
Bmw
Campueu
Chevrolet
Citroen
Dacia
Ferrari
Fiat
Harley Davidson
Honda
Honda Bikes
Hyundai
Kia
Lexus
Mazda
Nissan
Opel
Peugeot
Seat
Suzuki
Yamaha
Algorithms
Arabam
My BMW
BMW Türkiye
Campu.eu
My Dacia
Dacia Media Control
Fiat Yol Arkadaşım
Harley Davidson
Honda Bikes
Honda Connect
Mazda
myChevrolet
My Citroën
MyFerrari
myHyundai
Kia Connect
Kia Fan
MyKia
MyKia Chile
Lexus Lounge
Lexus Connect
MyNISSAN
Nissan Türkiye
My Opel
MyPeugeot
SEAT Online
Maruti Suzuki
Yamaha Motor Malaysia
@TotallyAvailable
Copy link
Contributor

I did notice (or was surprised) a couple "standouts" that seemed obvious go-tos in terms of coverage missing when I started using it as well.

But that's the beauty and "truthfulness"(?) of an actual open source Icon Pack.
We can see that absolutely massive backlog of requests, the work that's being done, the improvements on stuff that's already there (despite the lack of "request downtime", which I haven't even mentioned yet in a related Issue...)

And after being done covering the most obvious stuff I had the urge to... I might finally stop posting essays and actually get to work with those new Icons...
Imagine swapping those 2 things around, backlog no more.

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 18, 2023

Great work again @onuronsekiz ! I've made some modifications, mostly in sizing, but I've simplified some car logo's even more.

With #1804 in mind, I think it's good to think more about our designs, and how we can minify more, and at the same time, keep the right details from the logo's. Let me know what you think. :)

image
image
image

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 18, 2023

@TotallyAvailable ah yes, the standouts, that's indeed the beauty of the open-sourceness of the pack. Almost everyone starts contributing because they miss some of their icons. Some even stay to help out with requests, and that's amazing.

Co-Authored-By: onuronsekiz <76511536+onuronsekiz@users.noreply.github.com>
@onuronsekiz
Copy link
Contributor Author

More simplified and minifed icons, got it.
I will be more careful with designs next time.
By the way, I am gonna add icons to;

  • Kia Fan
  • Kia Connect
  • Dacia Media Control

So they won't look same as brand logo.
So please wait while I am working on them.

Dacia Media Control
Kia Connect
Kia Fan
@onuronsekiz
Copy link
Contributor Author

Uploaded mentioned additions.
It should be ready to merge.

Donnnno and others added 2 commits November 18, 2023 14:43
Co-Authored-By: onuronsekiz <76511536+onuronsekiz@users.noreply.github.com>
@Donnnno
Copy link
Collaborator

Donnnno commented Nov 18, 2023

Great!

@Donnnno Donnnno merged commit 5287ca7 into Arcticons-Team:main Nov 18, 2023
@onuronsekiz
Copy link
Contributor Author

Just a quick question, I made some additional car brand logos.
Yet some of them doesn't have an application in Play Store.
Or it is not available for my region so I can't find when I search.
I can't install the application, so I can't get item components.

Can I commit them without appfilter entries or should I ditch them?

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 18, 2023

Feel free to add them! Could be useful for in the future, or if people want to apply the icons manually to their setup.

@TotallyAvailable
Copy link
Contributor

Or someone with eyes on the commits willing to do some manual work or already using the app in question.

Might be an idea to have a "up for adoption" document with references to new or existing icons with unknown strings, are currently unused or have a lot of individual "per country/language" versions that need more coverage.
There's a lot more going on obviously than we see with our region bound "default" view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants