Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPCGatewayAttachment-Conversion needs to assess the parameters to decide on right resource #216

Open
kzehnter opened this issue Aug 22, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed resource_search_error A CF resource was not correctly translated to Terraform

Comments

@kzehnter
Copy link

Expected Behaviour:
AWS::EC2::VPCGatewayAttachment with InternetGatewayId Parameter should be converted into a aws_internet_gateway_attachment

Actual Behaviour:

  InternetGatewayVpcAttachment:
    Type: AWS::EC2::VPCGatewayAttachment
    Properties:
      InternetGatewayId: !Ref InternetGateway
      VpcId: !Ref VPC

gets converted to:

resource "aws_vpn_gateway_attachment" "internet_gateway_vpc_attachment" {
  vpc_id = aws_vpc.vpc.arn
}

Terraform has 2 different resources (aws_vpn_gateway_attachment and aws_internet_gateway_attachment) that should be chosen depending on the properties (VpnGatewayId and InternetGatewayId) in the AWS::EC2::VPCGatewayAttachment.

@shadycuz
Copy link
Member

Thanks for reporting this.

@shadycuz shadycuz added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed resource_search_error A CF resource was not correctly translated to Terraform labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed resource_search_error A CF resource was not correctly translated to Terraform
Projects
None yet
Development

No branches or pull requests

2 participants